[Feature] Descalificar participantes #98
Conversation
| email: string, | ||
| ofmiName: string, | ||
| preferredName: string, | ||
| shortReason: string, |
There was a problem hiding this comment.
Podemos hacer el shortReason un enum en types/participation.ts para poder tener type checking de estas razones?
| shortReason: string, | ||
| ): MailOptions => { | ||
| let longReason = shortReason; | ||
| switch (shortReason) { |
There was a problem hiding this comment.
Esto también podríamos tenerlo en types/participation.ts
There was a problem hiding this comment.
Puedes exponer esta API en la consola de /admin?
Es simplemente agregándolo a APIS en /src/components/admin/client
| message: `${firstError ? parseValueError(firstError) : "Invalid request body."}`, | ||
| }); | ||
| } | ||
| const { email, ofmiEdition, sendEmail, ...others } = Value.Cast( |
There was a problem hiding this comment.
Si haces Value.Check me parece que no tienes que usar
Borremoslo aquí
| message: `${firstError ? parseValueError(firstError) : "Invalid request body."}`, | ||
| }); | ||
| } | ||
| const { email, ofmiEdition, sendEmail, ...others } = Value.Cast( |
There was a problem hiding this comment.
Si haces Value.Check me parece que no tienes que usar
Borremoslo aquí
| ...others, | ||
| }, | ||
| }); | ||
| if (sendEmail) { |
There was a problem hiding this comment.
Mejor siempre enviemos correo :)
| return `${ofmiEdition}a-ofmi`; | ||
| export function friendlyOfmiName( | ||
| ofmiEdition: number, | ||
| formatted = false, |
There was a problem hiding this comment.
| formatted = false, | |
| humanReadable = false, |
| user User @relation(fields: [userId], references: [id]) | ||
| userId String | ||
| ofmi Ofmi @relation(fields: [ofmiId], references: [id]) | ||
| ofmiId String |
There was a problem hiding this comment.
En lugar de usar esto qué te parece si usamos ContestantParticipationId?
En realidad estamos descalificando su participación.
Esto haría más fácil por ejemplo findContestantByOfmiAndEmail
| } | ||
| } | ||
|
|
||
| async function updateParticipantDisqualification( |
There was a problem hiding this comment.
Esta solo nos sirve para los appealing verdad?
Si es así, podemos mejor separarlos en dos endpoints?
disqualifyParticipant.ts y setAppealResult (o algo parecido)
#93
Aun me falta agregar la columna al excel
Edit: Listo