-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Geo Shape Query #1058
base: release-branch.v6
Are you sure you want to change the base?
Conversation
Based on the elasticsearch and GeoJSON specification, this PR try to solve the olivere#939 supporting the follow types : * Circle * Envelope * Linestring * MultiLineString * MultiPoint * MultiPolygon * Point * Polygon Any suggestion would be appreciated. Change-Id: If7e6f59a3833da665e31e7ec179951780d82f9c2
Change-Id: I72ce5d9647ce5c55924cb563db49de4253ae792c
Coordinates []float64 `json:"coordinates"` | ||
} | ||
|
||
// NewCircle creates and initializes a new Circle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a method to verify the arguments?
for example: the order of coordinates, Lon and Lat or Lat and Lon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, no, there's not, I will implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some functions like this in geo_point.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are roughly based on GeoPoint.java
.
A few initial comments on this PR:
|
Can we use this PR instead of #956, i.e. do you try to implement the same thing? |
Based on the elasticsearch and GeoJSON specification, this PR tries to
solve the #939 supporting the follow types :
Any suggestion would be appreciated.