Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy to clipboard key to meta + c #4281

Conversation

lukecotter
Copy link
Contributor

The current keybinding for macos is meta + y (meta + 89) to match windows it should be meta + c (meta + 67)

fix: copy to clipboard key to meta + c
It was meta + y instead of meta + c

fixes: #4280

It was `meta + y` instead of `meta + c`
@olifolkerd
Copy link
Owner

Hey @lukecotter

Thanks for the PR, the concept of your PR is great, but im afraid you seem to have altered all the spacing in the file for some reason.

Please dont change the formatting of files in your PR's, only change the lines of code that actually result in the functionality changes you want.

As im doing a patch release today i will make this change directly myself, otherwise i would normally push it back for remediation.

Thanks for the fix.

Oli :)

@olifolkerd olifolkerd closed this Aug 27, 2023
@lukecotter
Copy link
Contributor Author

@olifolkerd
Sorry about that I think my prettier auto formatted.
I will disable it for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect key binding for copyToClipboard on mac
2 participants