Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple results returned by eth_estimateGas #3223

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

bylingo
Copy link
Contributor

@bylingo bylingo commented Jul 24, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #3223 (b00e47b) into dev (39c86b1) will increase coverage by 0.09%.
The diff coverage is 63.63%.

❗ Current head b00e47b differs from pull request most recent head df26def. Consider uploading reports for the commit df26def to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3223      +/-   ##
==========================================
+ Coverage   36.46%   36.55%   +0.09%     
==========================================
  Files         444      444              
  Lines       46606    46622      +16     
==========================================
+ Hits        16993    17041      +48     
+ Misses      28347    28320      -27     
+ Partials     1266     1261       -5     
Impacted Files Coverage Δ
app/config/config.go 26.87% <30.00%> (+0.14%) ⬆️
app/rpc/namespaces/eth/utils.go 32.00% <88.88%> (-7.72%) ⬇️
app/test_helpers.go 92.15% <92.59%> (+0.49%) ⬆️

... and 2 files with indirect coverage changes

@bylingo bylingo marked this pull request as ready for review August 3, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants