Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icamauth proto #2949

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

add icamauth proto #2949

wants to merge 1 commit into from

Conversation

ItsFunny
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #2949 (7a12c53) into dev (0d8075d) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a12c53 differs from pull request most recent head 244482e. Consider uploading reports for the commit 244482e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              dev    #2949   +/-   ##
=======================================
  Coverage   36.20%   36.20%           
=======================================
  Files         428      428           
  Lines       44828    44828           
=======================================
  Hits        16230    16230           
  Misses      27425    27425           
  Partials     1173     1173           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants