Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting display according to kind of screen computer or smartphonetablet #17

Conversation

ofaurax
Copy link
Owner

@ofaurax ofaurax commented Apr 29, 2024

Fixes #11

@ofaurax ofaurax force-pushed the 11-adapting-display-according-to-kind-of-screen-computer-or-smartphonetablet branch 2 times, most recently from e853649 to b9aee36 Compare April 29, 2024 13:38
@kimicol
Copy link
Collaborator

kimicol commented May 9, 2024

2 comments for computer screen display:

  • When there are a lot of scores, there are not aligned
    image

  • For one score, label of items could be added
    image
    Example here: "Compositeur : Beethoven, Arrangeur : Levasseur, Classification : F058"
    It would add clarity but it is not pretty, not sure what to chose.

@ofaurax
Copy link
Owner Author

ofaurax commented May 16, 2024

When there are a lot of scores, there are not aligned
image

What would be the desired behaviour?

label of items could be added

The whole box should be rethought:

  • youtube/musicainfo links should be elsewhere
  • identifier (Letter + 3 digits) doesn't need to be shown this big
  • Download link can be prettier

But perhaps this can be done in another branch, so we already provide something usable, before something pretty

@ofaurax
Copy link
Owner Author

ofaurax commented May 16, 2024

OK, so I put a "fixed" width (proportional to fixed font-size), it should be well-aligned now

@ofaurax ofaurax marked this pull request as ready for review June 6, 2024 16:27
@ofaurax ofaurax force-pushed the 11-adapting-display-according-to-kind-of-screen-computer-or-smartphonetablet branch from d085a0f to 76e8967 Compare June 7, 2024 15:54
@ofaurax ofaurax merged commit 2d83eda into main Jun 7, 2024
4 checks passed
@ofaurax ofaurax deleted the 11-adapting-display-according-to-kind-of-screen-computer-or-smartphonetablet branch June 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapting display according to kind of screen (computer or smartphone/tablet)
2 participants