Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A monolithic Dockerfile that actually works #351

Merged
merged 3 commits into from
Dec 23, 2017
Merged

A monolithic Dockerfile that actually works #351

merged 3 commits into from
Dec 23, 2017

Conversation

ibnesayeed
Copy link
Member

This implements #70. Running this should be as simple as:

$ docker image build -t ipwb .
$ docker container run -it --rm -v 5000:5000 ipwb

@codecov
Copy link

codecov bot commented Dec 23, 2017

Codecov Report

Merging #351 into master will decrease coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   24.31%   23.38%   -0.93%     
==========================================
  Files           6        6              
  Lines        1024     1193     +169     
  Branches      157      235      +78     
==========================================
+ Hits          249      279      +30     
- Misses        759      890     +131     
- Partials       16       24       +8
Impacted Files Coverage Δ
ipwb/replay.py 14.38% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7f59e...9b508cc. Read the comment docs.

Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, closes #70. Thanks again for your recent cycles getting ipwb into better shape.

@machawk1 machawk1 merged commit c41f956 into master Dec 23, 2017
@machawk1 machawk1 deleted the issue-70 branch December 23, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants