Skip to content

Commit

Permalink
Bump v3.0.0-beta.1 (breaking)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mirisuzanne
mirisuzanne committed Jun 19, 2017
1 parent cf8b8a1 commit 2ccf75c
Show file tree
Hide file tree
Showing 20 changed files with 89 additions and 31 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ susy-*.gem
*.DS_Store
.sass-cache
.rvmrc
.pages/
pkg/
*.sublime-*
docs/_build/
Expand Down
4 changes: 2 additions & 2 deletions .sassdoc/a-config.html
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .sassdoc/assets/css/json.css
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .sassdoc/assets/css/main.css
View file

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions .sassdoc/assets/css/theme.css
View file

This file was deleted.

Loading

5 comments on commit 2ccf75c

@robsonsobral
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne , hi!

I'm curious. Why to drop $count x $width syntax in columns? I loved this syntax. I even started to use it on my own mixins and functions.

@mirisuzanne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robsonsobral it's a fair question. I went back and forth on that for a while. In the end I realized I could simplify the parser/normalization dramatically by following the CSS Grid spec instead of inventing my own syntax. Wouldn't be hard to add back in if we feel like it's needed, but susy-repeat() felt like cleaner solution, and an opportunity to simplify.

@robsonsobral
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the list syntax is easier to understand and to learn. Everybody can understand at the first look. However, it's all a matter of personal preference.

I'll have to update two projects, I guess, which used the previous alphas. No problem.

@mirisuzanne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which are you referring to as the "list syntax"?

I agree, it's very easy to get caught up in personal syntax preferences. My hope was that this approach is teaching people how to use CSS Grid syntax, or allows people who know CSS Grid to use our syntax pretty interchangeably.

I also thought about allowing fr units, and then stripping them in normalization – since CSS Grid fr and our unitless numbers serve the same purpose. My only worry is that there might be small differences, and we don't want to stop people from using fr if there's a good reason for that instead of unitless.

@robsonsobral
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which are you referring to as the "list syntax"?

Ops! I'm sorry. This is what I mean.

columns: 4 x 120px

Please sign in to comment.