User specification / Operating system split #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustanddreams
force-pushed
the
os_agnostic_users
branch
from
6023b22
to
6000686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the separation between the type of OS we're targeting and the way users are specified.
The existing code always assumes numerical user ids are used with Unix-like systems while named users are used with Windows. While there are indeed strong requirements from docker and runc to use numerical user ids, other environments (such as the FreeBSD sandbox being worked on) work well with named users.
So this PR:
UnixandWindowstoByIdandByName.UnixandWindowsfor the dockerfile generation style, since what matters there is the OS being targetedchowncommands andtarheaders).This should not break anything (famous last words).