Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out jobs in progress when pruning Db_store #115

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Filter out jobs in progress when pruning Db_store #115

wants to merge 8 commits into from

Conversation

kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Sep 5, 2022 •
edited
Loading

Otherwise some jobs can get removed even before it started building if under heavy load for 10 minutes or if there is no output for that long too.

Building on iphito.ocamllabs.io
+++ Timeout!! (1 hour) +++
+++ Job cancelled +++

@MisterDA MisterDA requested a review from talex5 September 6, 2022 13:19
@kit-ty-kate kit-ty-kate marked this pull request as draft September 6, 2022 14:40
@MisterDA
Copy link
Contributor

Why does it matter to init preemptive with only one thread (and not use the default)? Do you use this as a kind of queue for database operations?

@kit-ty-kate
Copy link
Contributor Author

Do you use this as a kind of queue for database operations?

yes

@kit-ty-kate
Copy link
Contributor Author

I should use mutexes but we can see later. This is a WIP anyway and it's only for testing

@MisterDA MisterDA force-pushed the master branch 2 times, most recently from 89e84ac to ccd3f2f Compare February 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcgilchrist tmcgilchrist tmcgilchrist approved these changes

@talex5 talex5 Awaiting requested review from talex5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kit-ty-kate @MisterDA @tmcgilchrist