s3: parallel upload #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaszig
force-pushed
the
feature/parallel-upload
branch
6 times, most recently
from
860db8e
to
0c85abb
Compare
|
bump. |
glaszig
force-pushed
the
feature/parallel-upload
branch
from
0c85abb
to
a81ac06
Compare
glaszig
force-pushed
the
feature/parallel-upload
branch
from
a81ac06
to
8f54c0c
Compare
|
@imathis can we get this done? |
|
bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr introduces the use of threads to upload files in parallel -- inspired by
jekyll-s3.using this on a site with 18 files (636k) on a 14mbit dsl connection, it cuts the upload time consumption ~~by ~50%. before: ~6 seconds. after: ~3 seconds.~~ by ~25%. before: ~12 seconds. after: ~9 seconds.
this feature will also be configurable in
_deploy.ymlviaparallel: true|falseand defaults to true.i didn't get around refactoring quite a bit. sorry ;)