Update RSCT operator status #51
Conversation
manju956
commented
Oct 1, 2024
•
manju956
commented
- Update RSCT operator status based on observed status of pods spun by the operator
- Address requirements of the issue Release RSCT Operator #44
- Add required Cluster Service Version fields
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manju956 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @manju956! It looks like this is your first PR to ocp-power-automation/rsct-operator 🎉 |
manju956
force-pushed
the
rsct-operator-status
branch
5 times, most recently
from
9544aa3
to
c8774a0
Compare
manju956
force-pushed
the
rsct-operator-status
branch
from
c8774a0
to
606b665
Compare
| pods := &corev1.PodList{} | ||
|
|
||
| labelSelector := labels.SelectorFromSet(map[string]string{"app": currentDaemonSet.Name}) | ||
| listOpts := &client.ListOptions{Namespace: rsct.Namespace, LabelSelector: labelSelector} |
There was a problem hiding this comment.
instead of reading the pods, wondering if we can read the state of the daemonset itself and its healthiness
There was a problem hiding this comment.
the reason for choosing to inspect pod(s) status instead of daemonset state is because it carries multiple detailed states which are not useful. below is the RSCT daemonset state when its in running condition.
status: currentNumberScheduled: 1 desiredNumberScheduled: 1 numberAvailable: 1 numberMisscheduled: 0 numberReady: 1 observedGeneration: 1 updatedNumberScheduled: 1
manju956
force-pushed
the
rsct-operator-status
branch
3 times, most recently
from
c4f36e5
to
e16b880
Compare
Signed-off-by: manju956 <[email protected]> Address review comments Signed-off-by: manju956 <[email protected]>
manju956
force-pushed
the
rsct-operator-status
branch
from
e16b880
to
703c7bf
Compare
