Ensures availability of unzip & yq; Updates yq commands for v4 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiro Miyamoto <[email protected]>
hamzy
reviewed
Oct 20, 2021
| fi | ||
|
|
||
| which unzip 2>&1 >/dev/null || yum -y install unzip |
There was a problem hiding this comment.
nit hash also tests for the existence of an executable and also updates bash's cache of where programs are located.
There was a problem hiding this comment.
While refreshing bash's cache with a new search may not be much, I like hash is silent in stdout, and I wouldn't have to do the >/dev/null thing. Will update my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50, tested on RHEL 8.4 on ppc64le
Signed-off-by: Hiro Miyamoto [email protected]