Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal async decoder support #46

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Minimal async decoder support #46

wants to merge 10 commits into from

Commits on Jan 27, 2023

  1. refactor: some cosmetic changes to make rust and clippy happy

    @rklaehn
    rklaehn committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f2782dc View commit details
    Browse the repository at this point in the history

  2. refactor: do not require Read on DecoderShared 

    this is so DecoderShared can be used from async decoders
    @rklaehn
    rklaehn committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c9d0700 View commit details
    Browse the repository at this point in the history

  3. feature: add minimal, optional support for tokio async 

    for now just for the Decoder in inline and outboard mode,
not yet for the SliceDecoder.
    @rklaehn
    rklaehn committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    fa14072 View commit details
    Browse the repository at this point in the history

  4. feature: add AsyncRead for AsyncSliceDecoder 

    This requires some seek logic, but no actual seeking in the underlying inputs
    @rklaehn
    rklaehn committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    482f111 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. refactor: explicit states for reading and writing

    @rklaehn
    rklaehn committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    bc8af4e View commit details
    Browse the repository at this point in the history

  2. refactor: avoid the option 

    just give the state a case Done so we can implement take
    @rklaehn
    rklaehn committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    09ecead View commit details
    Browse the repository at this point in the history

  3. refactor: resolve weirdness with using buf_start to track end 

    we don't have to do this anymore now that we properly track state
    @rklaehn
    rklaehn committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    d44f5c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. refactor: some type aliases for clippy 

    also update comments
    @rklaehn
    rklaehn committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c1f7c9c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. refactor: add clone and debug

    @rklaehn
    rklaehn committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    44943bd View commit details
    Browse the repository at this point in the history

  2. feature: add into_inner 

    This can always succeed, because the SliceDecoder will never implement Seek
    @rklaehn
    rklaehn committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    2329a8f View commit details
    Browse the repository at this point in the history