This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
Stop processing flag multiple when a non-option flag is found #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we have a flag that accepts multiple values followed by a boolean flag and then positional arguments, the multiple flag will erroneously receive the arguments that come after the boolean flag. Example
myProg --extensions .js .ts --strict ./myDir1 ./myDir2 # extensions is set to [ '.js', '.ts', './myDir1', './myDir2' ]
This PR changes that behavior so boolean flags end the parsing just like option flags do.
myProg --extensions .js .ts --strict ./myDir1 ./myDir2 # extensions is set to [ '.js', '.ts' ]
Bug is due to
this.currentFlag
not being set for non-option (bool) flags in parse.ts lines 109-147