repository cleanups: remove 'findlib' files, rename desc and desr to descr #12205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. The Travis failure is unrelated. |
|
Just a side note: a request name that is just "cleanups" is a bad idea. It means people don't know whether to pay attention to the particular request or not because they don't know what it is about. |
hannesm
changed the title
|
@pmetzger good point, renamed. sorry. |
|
Looks good. Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does multiple changes
findlibfiles (see Remove findlib files #9328 for earlier discussion)descanddesrfiles todescr.chamo.sourceview.bufferswhich seems to be accidentally commited