Case insensitive substring test function #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octachron
reviewed
May 21, 2024
| let name_contains_s { name; _ } = | ||
| String.contains_s (String.lowercase_ascii name) pattern | ||
| in | ||
| let name_contains_s { name; _ } = String.is_sub_ignore_case pattern name in |
There was a problem hiding this comment.
It seems a bit perilous to assume that names fit in the ascii subset of English?
There was a problem hiding this comment.
You are right; it is not. Not sure how to handle this nicely here. This commit is just a refactoring. Any clues?
There was a problem hiding this comment.
If pulling uucp as dependency is ok: https://erratique.ch/software/uucp/doc/Uucp/Case/index.html#caselesseq looks like a good alternative to the lowercase_ascii normalization (even if does not cover "lookalike" search).
There was a problem hiding this comment.
This is a good idea. Uucp is already part of ocamlorg dependencies (by transitivity) so there's no downside to this.
There was a problem hiding this comment.
Issue on this: #2444
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.