Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety-checking hook to 'tryRunMigrationsWithEditUpdate' #21

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

alexfmpe
Copy link
Contributor

No description provided.

@alexfmpe alexfmpe requested a review from ali-abrar April 23, 2021 12:50
@alexfmpe alexfmpe marked this pull request as draft October 27, 2021 16:43
@alexfmpe
Copy link
Contributor Author

alexfmpe commented Feb 2, 2022

I think we ended up needing the hook to be Schema -> [WithPriority Edit] -> [WithPriority Edit] so we could reason about the intended schema (current one is available by querying the database) and not just reverse engineer intent from the diff.
e.g. we might be expecting a rename, and be able to confirm it on the schemas, but the diff will have a pair of unrelated column delete/add.
This was kept as a draft until I was more confident in the change since it was a breaking one (we could always come up with a new name)

@alexfmpe
Copy link
Contributor Author

alexfmpe commented Feb 2, 2022

I think we ended up needing the hook to be Schema -> [WithPriority Edit] -> [WithPriority Edit]

Should 9d8d8af be cherry picked here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants