Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refresh-token-grant-type.js #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zireael
Copy link

@Zireael Zireael commented May 16, 2020

For consistency shouldn't client.id be client.clientId? in:
if (token.client.id !== client.id) {
throw new InvalidGrantError('Invalid grant: refresh token is invalid');
}
Keeping old format with && switch for backwards compatibility:
if ((token.client.id !== client.id) && (token.client.id !== client.clientId)) {
throw new InvalidGrantError('Invalid grant: refresh token is invalid');
}

For consistency shouldn't client.id be client.clientId? in:
      if (token.client.id !== client.id) {
        throw new InvalidGrantError('Invalid grant: refresh token is invalid');
      }
Keeping old format with && switch for backwards compatibility:
      if ((token.client.id !== client.id) && (token.client.id !== client.clientId)) {
        throw new InvalidGrantError('Invalid grant: refresh token is invalid');
      }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant