Fix hostAliases to support multiple entries #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change and cannot be introduced like this. |
saravanan30erd
force-pushed
the
fix-hostalias
branch
from
d8b0b16
to
11c303f
Compare
|
@pierluigilenoci bumped the version and added artifact nodes, also updated readme and added example in default values.yaml file. |
|
@saravanan30erd, your pipeline is failing. Please take a look. |
pierluigilenoci
previously approved these changes
Nov 7, 2023
|
@saravanan30erd, can you please rebase your PR? |
pierluigilenoci
previously approved these changes
Nov 7, 2023
@pierluigilenoci Looks like you already rebased it. If there is anything I need to do? |
|
@saravanan30erd I'm waiting for a second opinion from @desaintmartin because this is a breaking change and must be taken care of. |
pierluigilenoci
previously approved these changes
Feb 28, 2024
pierluigilenoci
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Current
hostAliasesimplementation supports only one alias entry.It doesn't support to add two or more alias entries in /etc/hosts.
Refer: https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/#adding-additional-entries-with-hostaliases
We need flexibility to add multiple alias entries.