Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package type
so 2be9e21 is the output of playwright's npm init command, but it was unhappy with our package.json having
"type": "module"
.npx playwright test
outputi tried a whole bunch of weird things to get around the error, like precompiling the typescript to js in a
test-out
dir, but ran into other issues with that (it couldn't find any tests :o)removing
"type": "module"
from our package.json works fine for the test, but we still want it for when we publish to npm. open to ideas about how we can make it work for both cases!Storybook
got the web component tests working, using storybook as the reference for it, but it only works when storybook is already running. otherwise it takes SO long to boot up.
we could precompile the storybook in ci, then reference the static html file in the webserver (we might need to do this to host the storybook anyways), or write a custom html page. both seem complicated, but also open to ideas on this front