Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.10 into branch-25.02 #508

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Oct 21, 2024

Forward-merge triggered by push to branch-24.10 that creates a PR to keep branch-25.02 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

`rapidsai/shared-action-workflows/get-pr-info` was deleted in favor of `nv-gha-runners/get-pr-info`

rapidsai/shared-actions#11

Authors:
  - Christopher Harris (https://github.com/cwharris)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #500
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 21, 2024 23:15
Copy link
Author

rapids-bot bot commented Oct 21, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

jjacobelli and others added 2 commits October 22, 2024 19:41
This PR is replacing the `VAULT_HOST` variable with `AWS_ROLE_ARN`. This is required to use the new token service to get AWS credentials

Authors:
  - Jordan Jacobelli (https://github.com/jjacobelli)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #506
Overview of new classes added in this PR:

- `DynamicRouterBase`
  - Sink
    - `WritableProvider`, `ReadableAcceptor`, `SinkChannelOwner`
  - Source
    - `MultiWritableAcceptor`, `MultiReadableProvider`, `MultiSourceChannelOwner`
  - Runnable with ability to change number of outputs at runtime
  - Cannot be added to a Segment
  - Good backpressure support. Can still process requests if downstream blocks
  - `LambdaDynamicRouter`
    - Provide key function via lambda
- `DynamicRouterComponentBase`
  - Sink
    - `ForwardingWritableProvider`
  - Source
    - `MultiWritableAcceptor`, `MultiReadableProvider`, `MultiSourceChannelOwner`
  - Non-Runnable with ability to change number of outputs at runtime
  - Limited backpressure support. Will block if downstream blocks
  - `LambdaDynamicRouterComponent`
    - Provide key function via lambda
- `StaticRouterRunnableBase`
  - Sink
    - `WritableProvider`, `ReadableAcceptor`, `SinkChannelOwner`
  - Source
    - `MultiWritableAcceptor`, `MultiReadableProvider`, `MultiSourceChannelOwner`
  - Runnable with fixed number of outputs
  - Can be added to a Segment since it supports child outputs
  - Good backpressure support. Can still process requests if downstream blocks
  - `LambdaStaticRouterRunnable`
    - Provide key function via lambda
- `StaticRouterComponentBase`
  - Sink
    - `ForwardingWritableProvider`
  - Source
    - `MultiWritableAcceptor`, `MultiReadableProvider`, `MultiSourceChannelOwner`
  - Non-Runnable with fixed number of outputs
  - Can be added to a Segment since it supports child outputs
  - Limited backpressure support. Will block if downstream blocks
  - `LambdaStaticRouterComponent`
    - Provide key function via lambda

Closes #491

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #502
@rapids-bot rapids-bot bot requested review from a team as code owners October 22, 2024 22:58
@dagardner-nv dagardner-nv merged commit 365f8ea into branch-25.02 Oct 23, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants