Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft : Safe handling of control plane promises w/ clang16 #388

Closed
wants to merge 22 commits into from

IWYU fix

c10f1ba
Select commit
Loading
Failed to load commit list.
Closed

Draft : Safe handling of control plane promises w/ clang16 #388

IWYU fix
c10f1ba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 18, 2023 in 0s

88.73% of diff hit (target 73.11%)

View this Pull Request on Codecov

88.73% of diff hit (target 73.11%)

Annotations

Check warning on line 284 in cpp/mrc/src/internal/control_plane/client.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.cpp#L282-L284 

Added lines #L282 - L284 were not covered by tests

Check warning on line 89 in cpp/mrc/src/internal/control_plane/client.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.hpp#L89 

Added line #L89 was not covered by tests

Check warning on line 97 in cpp/mrc/src/internal/control_plane/client.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.hpp#L97 

Added line #L97 was not covered by tests

Check warning on line 103 in cpp/mrc/src/internal/control_plane/client.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.hpp#L103 

Added line #L103 was not covered by tests

Check warning on line 284 in cpp/mrc/src/internal/control_plane/client.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.hpp#L284 

Added line #L284 was not covered by tests

Check warning on line 290 in cpp/mrc/src/internal/control_plane/client.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

cpp/mrc/src/internal/control_plane/client.hpp#L290 

Added line #L290 was not covered by tests
View more details on Codecov