Skip to content

Commit

Permalink
Explicitly set the return type to match the python bindings
Browse files Browse the repository at this point in the history
  • Loading branch information
dagardner-nv committed Sep 16, 2024
1 parent 831925a commit e9ea972
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions python/mrc/_pymrc/src/segment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,9 @@ class SubscriberFuncWrapper : public mrc::pymrc::PythonSource<PyHolder>
{
DVLOG(10) << ctx.info() << " Starting source";
py::gil_scoped_acquire gil;
auto subscription = subscriber.get_subscription();
py::object py_sub = py::cast(subscription);
auto py_iter = m_gen_factory.operator()<py::iterator>(std::move(py_sub));
PySubscription subscription = subscriber.get_subscription();
py::object py_sub = py::cast(subscription);
auto py_iter = m_gen_factory.operator()<py::iterator>(std::move(py_sub));

Check warning on line 282 in python/mrc/_pymrc/src/segment.cpp

View check run for this annotation

Codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L280-L282

Added lines #L280 - L282 were not covered by tests
PyIteratorWrapper iter_wrapper{std::move(py_iter)};

for (auto next_val : iter_wrapper)
Expand Down

0 comments on commit e9ea972

Please sign in to comment.