Skip to content

Commit

Permalink
fix build interface includes (#514)
Browse files Browse the repository at this point in the history
build interface includes was accidentally using
```
.../build/conda/cuda-12.5/release/autogenerated/include
```
instead of 
```
.../build/conda/cuda-12.5/release/cpp/mrc/autogenerated/include
```
this PR fixes that, such when depending on mrc from down-stream libraries, the following error does not occur:
```
CMake Error in python/morpheus_llm/morpheus_llm/_lib/CMakeLists.txt:
  Imported target "mrc::pymrc" includes non-existent path

    "/home/coder/mrc/build/conda/cuda-12.5/release/autogenerated/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.
```

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #514
  • Loading branch information
cwharris authored Oct 24, 2024
1 parent 7abfdf7 commit 06d4ea1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/mrc/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ target_link_libraries(libmrc
target_include_directories(libmrc
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/autogenerated/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/autogenerated/include>
$<INSTALL_INTERFACE:include>
PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/src
Expand Down

0 comments on commit 06d4ea1

Please sign in to comment.