Skip to content

zcash_client_sqlite: Add wallet::orchard module & implement `put_re… #2603

zcash_client_sqlite: Add wallet::orchard module & implement `put_re…

zcash_client_sqlite: Add wallet::orchard module & implement `put_re… #2603

GitHub Actions / Clippy (MSRV) failed Mar 7, 2024 in 0s

Clippy (MSRV)

2 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 364 in zcash_client_sqlite/src/wallet/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

returning the result of a `let` binding from a block

error: returning the result of a `let` binding from a block
   --> zcash_client_sqlite/src/wallet/scanning.rs:364:9
    |
344 | /         let extended_range = extend_range(
345 | |             conn,
346 | |             &range,
347 | |             required_sapling_subtrees,
...   |
350 | |             wallet_birthday,
351 | |         )?;
    | |___________- unnecessary `let` binding
...
364 |           extended_range
    |           ^^^^^^^^^^^^^^
    |
    = note: `-D clippy::let-and-return` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
help: return the expression directly
    |
344 ~         
345 | 
  ...
356 | 
357 ~         extend_range(
358 +             conn,
359 +             &range,
360 +             required_sapling_subtrees,
361 +             SAPLING_TABLES_PREFIX,
362 +             params.activation_height(NetworkUpgrade::Sapling),
363 +             wallet_birthday,
364 +         )?
    |

Check failure on line 364 in zcash_client_sqlite/src/wallet/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

returning the result of a `let` binding from a block

error: returning the result of a `let` binding from a block
   --> zcash_client_sqlite/src/wallet/scanning.rs:364:9
    |
344 | /         let extended_range = extend_range(
345 | |             conn,
346 | |             &range,
347 | |             required_sapling_subtrees,
...   |
350 | |             wallet_birthday,
351 | |         )?;
    | |___________- unnecessary `let` binding
...
364 |           extended_range
    |           ^^^^^^^^^^^^^^
    |
    = note: `-D clippy::let-and-return` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
help: return the expression directly
    |
344 ~         
345 | 
  ...
356 | 
357 ~         extend_range(
358 +             conn,
359 +             &range,
360 +             required_sapling_subtrees,
361 +             SAPLING_TABLES_PREFIX,
362 +             params.activation_height(NetworkUpgrade::Sapling),
363 +             wallet_birthday,
364 +         )?
    |