Skip to content

zcash_client_sqlite: Add Orchard note commitments in put_blocks and… #2614

zcash_client_sqlite: Add Orchard note commitments in put_blocks and…

zcash_client_sqlite: Add Orchard note commitments in put_blocks and… #2614

Triggered via push March 8, 2024 04:06
Status Failure
Total duration 21m 26s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 5 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
returning the result of a `let` binding from a block: zcash_client_sqlite/src/wallet/scanning.rs#L364
error: returning the result of a `let` binding from a block --> zcash_client_sqlite/src/wallet/scanning.rs:364:9 | 344 | / let extended_range = extend_range( 345 | | conn, 346 | | &range, 347 | | required_sapling_subtrees, ... | 350 | | wallet_birthday, 351 | | )?; | |___________- unnecessary `let` binding ... 364 | extended_range | ^^^^^^^^^^^^^^ | = note: `-D clippy::let-and-return` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 344 ~ 345 | ... 356 | 357 ~ extend_range( 358 + conn, 359 + &range, 360 + required_sapling_subtrees, 361 + SAPLING_TABLES_PREFIX, 362 + params.activation_height(NetworkUpgrade::Sapling), 363 + wallet_birthday, 364 + )? |
returning the result of a `let` binding from a block: zcash_client_sqlite/src/wallet/scanning.rs#L364
error: returning the result of a `let` binding from a block --> zcash_client_sqlite/src/wallet/scanning.rs:364:9 | 344 | / let extended_range = extend_range( 345 | | conn, 346 | | &range, 347 | | required_sapling_subtrees, ... | 350 | | wallet_birthday, 351 | | )?; | |___________- unnecessary `let` binding ... 364 | extended_range | ^^^^^^^^^^^^^^ | = note: `-D clippy::let-and-return` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 344 ~ 345 | ... 356 | 357 ~ extend_range( 358 + conn, 359 + &range, 360 + required_sapling_subtrees, 361 + SAPLING_TABLES_PREFIX, 362 + params.activation_height(NetworkUpgrade::Sapling), 363 + wallet_birthday, 364 + )? |
Clippy (MSRV)
Clippy had exited with the 101 exit code
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (MSRV)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
protobuf consistency
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: supplypike/setup-bin@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.