[W6.2f][F09-3]Sarah Taaher Bonna #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyiii
reviewed
Sep 24, 2018
| } | ||
| // public CommandResult execute(){ | ||
| // throw new UnsupportedOperationException("This method should be implement in child classes"); | ||
| // } |
There was a problem hiding this comment.
Don't leave commented out code. Just go ahead and delete removed code, as we can recover them later
| @@ -70,4 +72,9 @@ public int getTargetIndex() { | |||
| public void setTargetIndex(int targetIndex) { | |||
| this.targetIndex = targetIndex; | |||
| } | |||
|
|
|||
| public boolean isMutating(String userCommandText) { | |||
There was a problem hiding this comment.
This method should have a header comment. If not, users of the method as well as those who overrides method will not know how exactly the method behaves. Also, as pointed out in the other PR, you should make use of polymorphism and implement the different behavior in individual sub classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.