[Yap Jin Fa] iP #64
Open
[Yap Jin Fa] iP #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2113-AY1920S2#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.
jichngan
reviewed
Feb 3, 2020
src/main/java/Duke.java
Outdated
| } | ||
| } | ||
|
|
||
| private static void displayBlahMessage() { |
There was a problem hiding this comment.
Is this method a debug method? By removing this method, does it improve readability?
src/main/java/Duke.java
Outdated
| System.out.println(DIVIDER); | ||
| } | ||
|
|
||
| private static void displayDoneMessage(String index) { |
There was a problem hiding this comment.
Perhaps can use a better variable name as index?
src/main/java/Duke.java
Outdated
|
|
||
| private static void displayDoneMessage(String index) { | ||
| int doneTaskIndex = Integer.parseInt(index) - 1; | ||
| if(Task.getTaskCount() <= doneTaskIndex){ |
There was a problem hiding this comment.
Missing spacing between (Task.getTaskCount() <= doneTaskIndex) and {.
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,20 @@ | |||
| public class Deadline extends Task{ | |||
src/main/java/Duke.java
Outdated
|
|
||
| private static void displayAddMessage() { | ||
| System.out.println(DIVIDER); | ||
| System.out.println(String.format(COMMAND_ADD_MESSAGE, tasks[Task.getTaskCount() -1], Task.getTaskCount())); |
There was a problem hiding this comment.
Missing space between Task.getTaskCount() - and 1.
src/main/java/Duke.java
Outdated
| //Solution below adapted from https://github.com/nus-cs2113-AY1920S2/contacts/blob/master/src/main/java/Contacts1.java | ||
| public static String[] splitInputLine(String rawUserInput, String regex) { | ||
| String[] split = rawUserInput.trim().split(regex, 2); | ||
| return split.length == 2? split : new String[] {split[0], ""}; // else no parameters |
src/main/java/Task.java
Outdated
| //Solution below adapted from https://www.baeldung.com/java-add-character-to-string | ||
| protected String stringBuilder(String input) { | ||
| StringBuilder sb = new StringBuilder(input); | ||
| sb.insert(3,":"); |
There was a problem hiding this comment.
Is 3 a magic number is this case? Perhaps making it into a constant variable?
Added documentation to the files
jinfayap
force-pushed
the
master
branch
4 times, most recently
from
72990cb
to
ce91df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.