[Tan Zheng Fu Justin] iP #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliu107
reviewed
Feb 4, 2020
src/main/java/Storage.java
Outdated
| import java.util.List; | ||
|
|
||
| public class Storage { | ||
| private List<Task> myTasks = new ArrayList<>(); |
There was a problem hiding this comment.
Is it enough to just import ArrayList class? Since I think you can directly define the type of myTasks as ArrayList.
src/main/java/Storage.java
Outdated
| return myTasks.get(index - 1); | ||
| } | ||
| catch(Exception e) { | ||
| return null; |
There was a problem hiding this comment.
Maybe you can use Printer to give some error messages if any exception has been caught.
src/main/java/Duke.java
Outdated
| String userInput; | ||
|
|
||
| userInput = in.nextLine(); | ||
| Task task = new Task(userInput); |
There was a problem hiding this comment.
Do you agree that the description of a task is actually the part after the first word of the user input? ( If according to the user input, we need create a task)
src/main/java/Duke.java
Outdated
| public static void echoUntilBye() { | ||
| boolean isBye = false; | ||
| while (!isBye) { | ||
| Task task = readFromUser(); |
There was a problem hiding this comment.
I think we can create a new Task only after we get the command which requires to do so.Since if the command is "list" or "bye", then there is no need to so.
…specific message for todo clas
added find for level-9
added A-JavaDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.