-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs regarding index of viewed object #363
Closed
hanscau
wants to merge
596
commits into
nus-cs2103-AY2425S1:master
from
AY2425S1-CS2103-F13-2:194-wrong-assignable-eventsvendors-when-traversing-between-views
Closed
Fix bugs regarding index of viewed object #363
hanscau
wants to merge
596
commits into
nus-cs2103-AY2425S1:master
from
AY2425S1-CS2103-F13-2:194-wrong-assignable-eventsvendors-when-traversing-between-views
+24,350
−7,519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reuse-between-event-and-vendor Consider model reuse between event and vendor
…age-message-for-commands Standardize and update message usage descriptors
…ide-for-assign-command Update User Guide for assign Command
…viewed-item-index Add relative index of viewed object
…ide-for-list-command Update User Guide for list Command
…unassign Update user guide for unassign command
…ide-for-edit-command Update UG for edit command
…ide-for-delete-command Update User Guide for delete Command
Update DG for logic component
…ide-for-find-command Update user guide for find command
Add view in UG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index of viewed object was dependent on filteredList to be updated which depended on viewedObject to be updated first. It is possible to update indexOfViewedObject together with viewedObject without waiting for filteredList to be updated. So it is refactored out