Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs regarding index of viewed object #363

Conversation

hanscau
Copy link

@hanscau hanscau commented Nov 7, 2024

Index of viewed object was dependent on filteredList to be updated which depended on viewedObject to be updated first. It is possible to update indexOfViewedObject together with viewedObject without waiting for filteredList to be updated. So it is refactored out

C5hives and others added 30 commits October 24, 2024 18:36
…reuse-between-event-and-vendor

Consider model reuse between event and vendor
…age-message-for-commands

Standardize and update message usage descriptors
C5hives and others added 28 commits November 6, 2024 23:17
…ide-for-assign-command

Update User Guide for assign Command
…viewed-item-index

Add relative index of viewed object
…ide-for-list-command

Update User Guide for list Command
…unassign

Update user guide for unassign command
…ide-for-edit-command

Update UG for edit command
…ide-for-delete-command

Update User Guide for delete Command
…ide-for-find-command

Update user guide for find command
@hanscau hanscau closed this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 92.68030% with 68 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/eventtory/MainApp.java 0.00% 13 Missing ⚠️
.../main/java/seedu/eventtory/model/ModelManager.java 95.51% 0 Missing and 7 partials ⚠️
...ttory/model/association/UniqueAssociationList.java 83.33% 4 Missing and 2 partials ⚠️
...enttory/logic/commands/util/IndexResolverUtil.java 87.50% 0 Missing and 4 partials ⚠️
...u/eventtory/storage/JsonSerializableEventTory.java 91.30% 1 Missing and 3 partials ⚠️
...eedu/eventtory/logic/parser/EditCommandParser.java 93.87% 0 Missing and 3 partials ⚠️
...ava/seedu/eventtory/model/util/SampleDataUtil.java 0.00% 3 Missing ⚠️
.../seedu/eventtory/storage/JsonEventToryStorage.java 85.71% 3 Missing ⚠️
.../main/java/seedu/eventtory/logic/LogicManager.java 84.61% 2 Missing ⚠️
...edu/eventtory/logic/commands/EditEventCommand.java 96.72% 0 Missing and 2 partials ⚠️
... and 13 more
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/eventtory/AppParameters.java 95.65% <ø> (ø) 12.00 <0.00> (?)
src/main/java/seedu/eventtory/Main.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...main/java/seedu/eventtory/commons/core/Config.java 77.27% <ø> (ø) 9.00 <0.00> (?)
...java/seedu/eventtory/commons/core/GuiSettings.java 76.92% <ø> (ø) 8.00 <0.00> (?)
.../java/seedu/eventtory/commons/core/LogsCenter.java 78.78% <ø> (ø) 5.00 <0.00> (?)
...ain/java/seedu/eventtory/commons/core/Version.java 82.50% <ø> (ø) 19.00 <0.00> (?)
...java/seedu/eventtory/commons/core/index/Index.java 100.00% <ø> (ø) 11.00 <0.00> (?)
...ttory/commons/exceptions/DataLoadingException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...tory/commons/exceptions/IllegalValueException.java 100.00% <ø> (ø) 2.00 <0.00> (?)
...ain/java/seedu/eventtory/commons/util/AppUtil.java 88.88% <ø> (ø) 5.00 <0.00> (?)
... and 89 more

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants