[Jun Wei] iP #495
Open
[Jun Wei] iP #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends Task { | |||
There was a problem hiding this comment.
You might want to add the javadoc/comment header for the classes and methods! Refer to this
src/main/java/Duke.java
Outdated
| @@ -1,10 +1,200 @@ | |||
| import java.io.*; | |||
There was a problem hiding this comment.
Should this import statement be listed explicitly?
src/main/java/Duke.java
Outdated
| System.out.println(greeting); | ||
| File folder = new File("data"); | ||
| folder.mkdir(); | ||
| // System.out.println(file.mkdir()); |
There was a problem hiding this comment.
It might be a good idea to delete unused code! 😄
src/main/java/Duke.java
Outdated
| System.out.println("____________________________________________________________"); | ||
| System.out.println("Here are the tasks in your list:"); | ||
| /* | ||
| for (int i = 0; i < count; i++) { |
There was a problem hiding this comment.
Might want to clean this up also!
src/main/java/Task.java
Outdated
|
|
||
| public Task(String description) { | ||
| this.description = description; | ||
| this.isDone = false; |
src/main/java/Event.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Event extends Task { | |||
|
|
|||
| protected String at; | |||
There was a problem hiding this comment.
Variable name can be more descriptive!
src/main/java/Todo.java
Outdated
| public String toString() { | ||
| return "[T]" + super.toString(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should end every file with a new line
src/main/java/Deadline.java
Outdated
|
|
||
| public Deadline(String description, String by) { | ||
| super(description); | ||
| this.by = by; |
There was a problem hiding this comment.
Can give a more descriptive variable naming!
src/main/java/DukeException.java
Outdated
| @@ -0,0 +1,13 @@ | |||
| public class DukeException extends Exception { | |||
| public String error; | |||
There was a problem hiding this comment.
Might want to give a description to this variable as it is public
src/main/java/Task.java
Outdated
| } | ||
|
|
||
| public String getDesription() { | ||
| return this.description; |
added 16 commits
September 9, 2021 01:46
A-Assertions
A-CodeQuality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DukePro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: