-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jun Wei] iP #495
base: master
Are you sure you want to change the base?
[Jun Wei] iP #495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall! Maybe an improvement is to write javadocs for the methods and classes. Another one is to introduce package to the files.
src/main/java/Deadline.java
Outdated
@@ -0,0 +1,14 @@ | |||
public class Deadline extends Task { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add the javadoc/comment header for the classes and methods! Refer to this
src/main/java/Duke.java
Outdated
@@ -1,10 +1,200 @@ | |||
import java.io.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this import statement be listed explicitly?
src/main/java/Duke.java
Outdated
System.out.println(greeting); | ||
File folder = new File("data"); | ||
folder.mkdir(); | ||
// System.out.println(file.mkdir()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to delete unused code! 😄
src/main/java/Duke.java
Outdated
System.out.println("____________________________________________________________"); | ||
System.out.println("Here are the tasks in your list:"); | ||
/* | ||
for (int i = 0; i < count; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to clean this up also!
src/main/java/Task.java
Outdated
|
||
public Task(String description) { | ||
this.description = description; | ||
this.isDone = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use this here?
src/main/java/Event.java
Outdated
@@ -0,0 +1,14 @@ | |||
public class Event extends Task { | |||
|
|||
protected String at; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable name can be more descriptive!
src/main/java/Todo.java
Outdated
public String toString() { | ||
return "[T]" + super.toString(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should end every file with a new line
src/main/java/Deadline.java
Outdated
|
||
public Deadline(String description, String by) { | ||
super(description); | ||
this.by = by; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can give a more descriptive variable naming!
src/main/java/DukeException.java
Outdated
@@ -0,0 +1,13 @@ | |||
public class DukeException extends Exception { | |||
public String error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to give a description to this variable as it is public
src/main/java/Task.java
Outdated
} | ||
|
||
public String getDesription() { | ||
return this.description; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use done here?
A-Assertions
A-CodeQuality
DukePro
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
main
method: