-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ming Gao Rickie Li] iP #469
Open
MGRL2201
wants to merge
38
commits into
nus-cs2103-AY2122S1:master
Choose a base branch
from
MGRL2201:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 016ad8d - Browse repository at this point
Copy the full SHA 016ad8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d81e3b0 - Browse repository at this point
Copy the full SHA d81e3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87638eb - Browse repository at this point
Copy the full SHA 87638ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f141e7 - Browse repository at this point
Copy the full SHA 7f141e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad65ad1 - Browse repository at this point
Copy the full SHA ad65ad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2efbd - Browse repository at this point
Copy the full SHA 2a2efbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 974d93a - Browse repository at this point
Copy the full SHA 974d93aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4b212f - Browse repository at this point
Copy the full SHA b4b212fView commit details
Commits on Aug 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a2b75e - Browse repository at this point
Copy the full SHA 8a2b75eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5927253 - Browse repository at this point
Copy the full SHA 5927253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 344c259 - Browse repository at this point
Copy the full SHA 344c259View commit details -
Configuration menu - View commit details
-
Copy full SHA for eddbc35 - Browse repository at this point
Copy the full SHA eddbc35View commit details -
Configuration menu - View commit details
-
Copy full SHA for e376a76 - Browse repository at this point
Copy the full SHA e376a76View commit details -
Configuration menu - View commit details
-
Copy full SHA for f334294 - Browse repository at this point
Copy the full SHA f334294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e24a6c - Browse repository at this point
Copy the full SHA 1e24a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04d6408 - Browse repository at this point
Copy the full SHA 04d6408View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e270b5 - Browse repository at this point
Copy the full SHA 0e270b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd59051 - Browse repository at this point
Copy the full SHA bd59051View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad2179 - Browse repository at this point
Copy the full SHA 8ad2179View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3369de3 - Browse repository at this point
Copy the full SHA 3369de3View commit details
Commits on Sep 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c12c5a7 - Browse repository at this point
Copy the full SHA c12c5a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e99d62 - Browse repository at this point
Copy the full SHA 2e99d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22c64b4 - Browse repository at this point
Copy the full SHA 22c64b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed5c92c - Browse repository at this point
Copy the full SHA ed5c92cView commit details
Commits on Sep 9, 2021
-
There is no code in place to indicate possible bugs. Assertion statements have been added to Duke class to ensure user input and program output are not null. The impact of assertions on performance is low and provides a safety net to ensure the user input and program output are as expected.
Configuration menu - View commit details
-
Copy full SHA for 88616f7 - Browse repository at this point
Copy the full SHA 88616f7View commit details -
Merge pull request #1 from MGRL2201/branch-A-Assertions
Branch A-Assertions
Configuration menu - View commit details
-
Copy full SHA for 4155640 - Browse repository at this point
Copy the full SHA 4155640View commit details -
The code needs to be more readable and abstract. Further abstracting code has made the code easier to read and follow along. Abstracting shortens method length and good naming of abstracted methods allow for more readable code.
Configuration menu - View commit details
-
Copy full SHA for 3a9ebac - Browse repository at this point
Copy the full SHA 3a9ebacView commit details -
Merge pull request #2 from MGRL2201/branch-A-CodeQuality
Code quality is not great.
Configuration menu - View commit details
-
Copy full SHA for 3b2f505 - Browse repository at this point
Copy the full SHA 3b2f505View commit details -
Configuration menu - View commit details
-
Copy full SHA for 472fac4 - Browse repository at this point
Copy the full SHA 472fac4View commit details -
Merge pull request #3 from MGRL2201/BCD-Extension
added update function
Configuration menu - View commit details
-
Copy full SHA for 07688eb - Browse repository at this point
Copy the full SHA 07688ebView commit details
Commits on Sep 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for caf4dfa - Browse repository at this point
Copy the full SHA caf4dfaView commit details
Commits on Sep 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1a9c8fe - Browse repository at this point
Copy the full SHA 1a9c8feView commit details
Commits on Sep 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d75e934 - Browse repository at this point
Copy the full SHA d75e934View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a4400 - Browse repository at this point
Copy the full SHA 91a4400View commit details -
Configuration menu - View commit details
-
Copy full SHA for 341b156 - Browse repository at this point
Copy the full SHA 341b156View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61841c2 - Browse repository at this point
Copy the full SHA 61841c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cafd45e - Browse repository at this point
Copy the full SHA cafd45eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5716959 - Browse repository at this point
Copy the full SHA 5716959View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.