[Jerry Ho] Duke Increments #451

itsjerryho · 2020-08-27T14:20:12Z

Include Commits for Week 2

Edit runtest.txt to javac all java files and replace code with symbols in Task.java

…sic Exceptionhandling

…ption handling

- add various imports

…rt boolean isDone

- saveDataToList is able to add tasks (in String form) to ArrayList

- Modify Deadline.java to store dates as a LocalDate object and time as a String. - Update Deadline handling in Duke.java

…on and fix infinite loop bug. - Fix bug that is preventing bye command from exiting the program

lerxcl

LGTM. Overall, the code logic flows well. However, you should do more OOP and correct some of the syntax, good effort!

lerxcl · 2020-09-02T08:27:29Z

src/main/java/Duke.java

+    }
+
+    public static void printMessage(String s) {
+        String output = String.format("____________________________________________________________\n%s\n" +


The "+" should be in the next line instead.

lerxcl · 2020-09-02T08:28:36Z

src/main/java/Duke.java

+    public static void saveToDisk(ArrayList<Task> lst) {
+        String filePath = "./data/data.txt";
+        String info = "";
+        for (int i = 0; i < lst.size(); i ++) {


There should not be a spacing between "i" and "++".

lerxcl · 2020-09-02T08:36:07Z

src/main/java/Duke.java

+import java.util.Scanner;
+import java.util.ArrayList;
+import java.io.File;
+
 public class Duke {


I have noticed that your Duke class may have too many methods (a little cluttered), and seeing that you have not merged "branch-A-OOP" into master, I am not sure whether you have create new classes to adhere to OOP principles?

lerxcl · 2020-09-02T08:38:22Z

src/main/java/Duke.java

+        String greetings = "Hello! I'm Duke, your personal assistant.\nWhat can I do for you?";
+        printMessage(greetings);
+
+        ArrayList<Task> lst = new ArrayList<>();


A better practice might be to split the instantiation of "lst".

After your import statements, it could be List lst;
Then in your Duke constructor: this.lst = new ArrayList<>();

lerxcl · 2020-09-02T08:39:22Z

src/main/java/Duke.java

+    }
+    public static void mainLogic(Scanner sc, ArrayList<Task> lst) {
+
+        while (true) {


It might not be too good of practice to use "while (true)", as it is hard to tell what is your terminating condition (and there is a chance of an infinite loop)?

lerxcl · 2020-09-02T08:40:07Z

src/main/java/DukeException.java

@@ -0,0 +1,5 @@
+public class DukeException extends Exception{


A spacing after "Exception" will look nicer!

lerxcl · 2020-09-02T08:41:36Z

src/main/java/ToDo.java

@@ -0,0 +1,14 @@
+public class ToDo extends Task{


Same as mentioned in DukeException class.

lerxcl · 2020-09-02T08:42:27Z

src/main/java/Task.java

+    }
+
+    public String toText(String type) {
+        int doneInt = this.isDone ? 1 : 0;


It might be better to use Enum to represent 1 and 0, as it might look like "magic numbers".

hyngkng

I like your overall naming of methods, just have to ensure all of them are consistent with the coding standard! :)

hyngkng · 2020-09-03T00:10:00Z

src/main/java/Duke.java

+        }
+        return newTask;
+    }
+    public static void mainLogic(Scanner sc, ArrayList<Task> lst) {


Perhaps the method name could have been a verb instead? Eg. parseCommand.

Yes, I also found this in other classes i.e. method invalidInput() in Duke class perhaps can also be changed to a verb?

- Command Line Interfaace is not working at the moment

- Remove scanner from Ui.java - Add a few Todos

- Program previously exit without saving task to data.txt

- Edit Deadline and Event to extend TimedTask

- Remove AdditionalInfo and Common classes - Add Specific Command Classes (Add, Delete, Done, Exit, Find, Invalid, List, PrintTask)

- Shift execute command logic out of Duke.java into the Command class itself - Remove additionalInfo from Command class and add storage, taskList and userInput to Command class - Create TimedTask, which is a super class for both Deadline and Event classes - Shift main parsing logic out of Parser into specific Command classes - Edit Storage class to handle change in Parsing style - Create enum for Task.java - Update Ui and remove Scanner and CLI related commands from Ui - Remove AdditionalInfo from ParserTest (still in progress)

Merge Branch A Assertions

# Conflicts: # src/main/java/duke/AdditionalInfo.java

- Find is now able to search using keyword that is not case-sensitive

Implement BetterSearch feature

- Add JUnit tests in ParserTest - Add TaskListTest

- Add padding - Change photo of Duke

itsjerryho added 28 commits August 20, 2020 20:25

Add Scanner and Implement Greet, Echo, Exit

b0b06c7

Import ArrayList

a240abd

Add ability to store text and display back to user when requested

affd926

Add Task Class

79d4d42

Add markAsDone to Task Class

5a1fcf7

Add getDescription to Task Class

266db70

Change ArrayList from String to Task and modify display of list items

84ccdbd

Create method printTask and add mark as done feature

c0f21c4

Remove printTask from Duke.java and Override Task's toString method

529f823

Add Deadline class

62872cd

Add ToDo Class

1bd86c5

Add Event Class

59b5d8e

Integrate Deadline, ToDo and Event to Duke

22a75bb

Modify EXPECTED.txt, input.txt to include test case.

2e8dec8

Edit runtest.txt to javac all java files and replace code with symbols in Task.java

Add DukeException.java

9d1cf01

Seperate mainLogic from main() and create a createTask method. Add ba…

a97cea3

…sic Exceptionhandling

Add delete function

e7c27be

Add additional exception handling, fixed early exiting bug after exce…

79740e0

…ption handling

Add printMessage method to output messages with lines

4514a22

Add toText method to Deadline, Event and Task classes

f395cb4

Add writeToFile, saveToDisk and readFileContents method to Duke.java

b046dde

- add various imports

Add gitignore for data.txt

b524ea4

Add new constructor method to Deadline, Task, Event and ToDo to suppo…

519147a

…rt boolean isDone

Add saveDataToList method to Duke.java

9182971

- saveDataToList is able to add tasks (in String form) to ArrayList

Add LocalDate support to Deadline.java and Duke.java

b5cc47b

- Modify Deadline.java to store dates as a LocalDate object and time as a String. - Update Deadline handling in Duke.java

Merge branch 'branch-Level-7'

0a2925a

Merge branch 'branch-Level-8'

fca52df

Modify Deadline.java to make it compatible with DateTime implementati…

b3778fe

…on and fix infinite loop bug. - Fix bug that is preventing bye command from exiting the program

lerxcl reviewed Sep 2, 2020

View reviewed changes

hyngkng reviewed Sep 3, 2020

View reviewed changes

itsjerryho and others added 30 commits September 8, 2020 11:14

Merge branch 'branch-A-CheckStyle'

6366d0a

Add DialogBox, Launcher, Main and MainWindow for GUI support

2cef4c2

Add images and fxml files for DialogBox and MainWindow

e92b0ef

Add support for Duke GUI

9732544

- Command Line Interfaace is not working at the moment

Make minor edits

28aafcc

- Remove scanner from Ui.java - Add a few Todos

Fix bug in Duke.java

f886b94

- Program previously exit without saving task to data.txt

Make minor changes to build.gradle and fxml files to remove warnings

a343896

Add assertions to TaskList.java

c6c5573

Add assertion to AdditionalInfo.java

ff195ae

Add assertion to build.gradle

3d01210

Create TimedTask

5a7755e

- Edit Deadline and Event to extend TimedTask

Refactor Code

d13b712

- Remove AdditionalInfo and Common classes - Add Specific Command Classes (Add, Delete, Done, Exit, Find, Invalid, List, PrintTask)

Add enums for Task class

1c07ea6

Merge pull request #1 from printinghelloworld/branch-A-Assertions

72f40c7

Merge Branch A Assertions

Merge branch 'master' into branch-A-CodeQuality

5922b84

# Conflicts: # src/main/java/duke/AdditionalInfo.java

Merge branch 'branch-A-CodeQuality'

fefab25

Merge branch 'A-Enums'

39df444

Implement BetterSearch feature

5bad734

- Find is now able to search using keyword that is not case-sensitive

Merge pull request #3 from printinghelloworld/branch-C-BetterSearch

690abb3

Implement BetterSearch feature

Add functionality to delete multiple tasks at one go

97fa23b

Merge branch 'branch-C-MassOps'

a904225

Minor edits to FindCommand

c7e4fc8

Edit README.md

32a730f

Merge branch 'branch-A-UserGuide'

86ad76d

Add Javadocs and Checkstyle

4df3c01

Increase JUnit testing

0af3ecf

- Add JUnit tests in ParserTest - Add TaskListTest

Improve GUI

84b52a4

- Add padding - Change photo of Duke

Final changes to Duke

656baa6

Merge branch 'branch-A-BetterGui'

498ee0f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Jerry Ho] Duke Increments #451

[Jerry Ho] Duke Increments #451

itsjerryho commented Aug 27, 2020 •

edited

Loading

lerxcl left a comment

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

lerxcl Sep 2, 2020

hyngkng left a comment

hyngkng Sep 3, 2020

michael-setia Sep 3, 2020

		@@ -0,0 +1,5 @@
		public class DukeException extends Exception{

[Jerry Ho] Duke Increments #451

Are you sure you want to change the base?

[Jerry Ho] Duke Increments #451

Conversation

itsjerryho commented Aug 27, 2020 • edited Loading

lerxcl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyngkng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itsjerryho commented Aug 27, 2020 •

edited

Loading