[W5][T12-1] Zhang Shaoqian #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Useful changes. The printing is more clear now. The coding style is also coherent with the rest of the files. |
|
It looks really nice now! Do you think it might be useful to have a function which takes in a number and returns the number of indentations accordingly? |
|
Good enhancement! This will help in printing clearly. Maybe we can use this to create user profile later on and print the user details in a proper profile number. |
bqnguyen94
approved these changes
Feb 14, 2019
| /** | ||
| * Clears the address book. | ||
| */ | ||
| public class ClearCommand extends Command { | ||
|
|
||
| public static final String COMMAND_WORD = "clear"; | ||
| public static final String MESSAGE_USAGE = "Clears address book permanently.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Clears address book permanently.\n" |
There was a problem hiding this comment.
I believe this is a (intended?) bug actually. Good job spotting it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty printing in the
helpcommandBefore, the
helpcommand prints everything without proper indentation so it looks very messy. Now indentations are added for the "parameter" and "example" lines.