[W5][T12-1]Zhang Chenxi #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 13, 2019 00:37
add groupPerson method in UniquePersonList class
add groupPrepare method
add the description of highlight(group) function
|
The grouping feature can be really useful :)You just need to add some tests! |
nerrons
suggested changes
Feb 13, 2019
| @@ -37,6 +37,8 @@ protected DuplicatePersonException() { | |||
|
|
|||
| private final List<Person> internalList = new ArrayList<>(); | |||
|
|
|||
| private final List<Person> groupedPersonList = new ArrayList<>(); | |||
There was a problem hiding this comment.
Perhaps add comments to groupedPersonList and explain what it does and why do we need this?
|
Really nice enhancement! We can maybe use this enhancement for group related activities that we have in our mind for the final project. |
bqnguyen94
requested changes
Feb 14, 2019
| @@ -111,6 +111,26 @@ Deletes the 2nd person in the address book. | |||
| `delete 1` + | |||
| Deletes the 1st person in the results of the `find` command. | |||
|
|
|||
| == Highlighting a person : `group` | |||
|
|
|||
| Deletes the specified person from the address book. Irreversible. + | |||
| public CommandResult execute() { | ||
| try { | ||
| final ReadOnlyPerson target = getTargetPerson(); | ||
| addressBook.removePerson(target); |
There was a problem hiding this comment.
Uhm this will remove the target person from address book?
| @@ -15,6 +15,7 @@ | |||
| import seedu.addressbook.commands.ClearCommand; | |||
| import seedu.addressbook.commands.Command; | |||
| import seedu.addressbook.commands.DeleteCommand; | |||
| import seedu.addressbook.commands.GroupCommand; | |||
There was a problem hiding this comment.
This import is in wrong order since import statements are sorted alphabetically :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.