[W5][W13-1]Gong Changda #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A very useful feature to make finding a particular person easier. However, I recommend you to add @OverRide annotations to methods that you override from the superclass, so the compiler and detect any mistakes you've made i.e.overriding the wrong class |
tristonpang
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Overall good effort @GongChangda ! I hope adding a new command has allowed you to better understand how this AB is structured. Please close this PR when you have seen this review.
| import seedu.addressbook.util.TestUtil; | ||
|
|
||
|
|
||
| public class SortCommandTest { |
There was a problem hiding this comment.
Good effort in writing JUnit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new command sort which sorts all persons in the addressbook according to their full-name in ascending order.