[W5][W13-1]Yong Xin Shen #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appropriate enhancement to show more details for one person. Can improve the date and time formatting to make it more readable for users |
|
Displaying the time when a person was added is certainly a useful feature. You can further improve your code by adding some I/O tests for this feature. |
tristonpang
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Good effort @amuletxheart ! Do try adding or editing a command in your free time, as it will also help to improve your understanding of the AB structure. Please close this PR when you have seen this review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new person is added, the system records the current time. When doing a list command, the timeAdded attribute is displayed in addition to the previous attributes.