Update canvas, regenerate lock #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason this one isn't being merged and releasing a new version of this package? This allows this package to be built at all on node >= v13 due to this issue which is solved in canvas v2.6.1: Automattic/node-canvas#1485 cc @jo |
Mike-Dunton
reviewed
Jun 9, 2020
package.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| "url": "https://github.com/null2/color-thief/issues" | |||
| }, | |||
| "dependencies": { | |||
| "canvas": "~2.5.0" | |||
| "canvas": "~2.6.0" | |||
There was a problem hiding this comment.
Suggested change
| "canvas": "~2.6.0" | |
| "canvas": "~2.6.1" |
There was a problem hiding this comment.
You will have to update the package-lock.json again.
There was a problem hiding this comment.
@Mike-Dunton Already resolves to the 2.6.1 vers. https://github.com/null2/color-thief/pull/17/files#diff-32607347f8126e6534ebc7ebaec4853dR356
There was a problem hiding this comment.
Whoops. I was wrong. ~ include everything greater than a particular version in the same minor range.
[Enhancement] Canvas bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.