Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canvas, regenerate lock #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

James1x0
Copy link

No description provided.

@tsheaff
Copy link

tsheaff commented Jun 4, 2020

Is there a reason this one isn't being merged and releasing a new version of this package? This allows this package to be built at all on node >= v13 due to this issue which is solved in canvas v2.6.1: Automattic/node-canvas#1485

cc @jo

package.json Outdated
@@ -16,7 +16,7 @@
"url": "https://github.com/null2/color-thief/issues"
},
"dependencies": {
"canvas": "~2.5.0"
"canvas": "~2.6.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"canvas": "~2.6.0"
"canvas": "~2.6.1"

Copy link

@Mike-Dunton Mike-Dunton Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to update the package-lock.json again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I was wrong. ~ include everything greater than a particular version in the same minor range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants