2016 update - Support for new Principal Dates page #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
|
Currently the code at commit 145aa37 appears to fetch all the new dates, however there are many duplicates for some reason. I'll need to do some more testing to get to the bottom of this. Also the dates themselves will need some full-pipeline testing - @lberezy (or @crozone?) - some help from someone with an active student timetable would be much appreciated! I will probably post this into the CISSA group again for testing as well though. |
nuclearpidgeon
changed the title
nuclearpidgeon
added a commit
that referenced
this pull request
Feb 1, 2016
2016 update - support for new Principal Dates page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a report from @lberezy in issue #3, it has been revealed that the great institution that is the University of Melbourne has changed both the layout, and the URL, of the page that they present their Principal Dates from - a move that has no doubt broken both the dodgy jQuery content scrapers of unofficial UoM plugins everywhere, and the hearts of their authors.
This PR is for an update to the plugin to cope with these monstrous bureaucratic changes, and also hopefully to provide some comforting descriptive comments to any future developer (myself included) who edits this code in the future.