Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package creating from build.fsproj to github actions #838

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Nov 2, 2024

Changes:

  • Package creating is moved from build.fsproj to github actions via dotnet pack
  • Version for nuget package now is getting from <Version>6.0.0</Version> property in NSubstitute.csproj, not from git tags
  • Update github actions for separate release packages and documentation
  • Unusable code is removed from build.fsproj
  • Added -p:CI=true to enable following properties for Deterministic Build and Source Link from NSubstitute.csproj
  <PropertyGroup Condition="'$(CI)' == 'True'">
    <!--Deterministic Build and Source Link settings -->
    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
    <EmbedUntrackedSources>true</EmbedUntrackedSources>
    <IncludeSymbols>true</IncludeSymbols>
    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
  </PropertyGroup>

after this change build.fsproj will be used only for documentation examples validation & documentation static generation

related #830

@Romfos Romfos requested a review from dtchepak November 2, 2024 12:24
@Romfos Romfos marked this pull request as ready for review November 2, 2024 13:13
@Romfos Romfos mentioned this pull request Nov 2, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant