Enhancements for RANGE tests #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2024 20:13
Signed-off-by: Evgeniy Zayats <[email protected]>
Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
As I remember there are some tests about it already, but @evgeniiz321, can prove it. |
carpawell
reviewed
Jun 4, 2024
| file_ranges_to_test.append((0, parts[0][1] + parts[1][1] - 1)) | ||
| # range requires more than two children (it includes OR does not include the first and the last children) | ||
| file_ranges_to_test.append((0, complex_object_size - 1)) | ||
| file_ranges_to_test.append((parts[0][1] + 1, complex_object_size - parts[0][1] - parts[-1][1] - 1)) |
There was a problem hiding this comment.
looks working correctly but really relies on the fact that there will always be more than two parts, not sure if it is error-proof
There was a problem hiding this comment.
With the current settings there always will be more than two parts. If in the future we will update something, we will update this accordingly. Making an error-proof test usually is a waste of time.
evgeniiz321
force-pushed
the
ezayats/ranges
branch
from
4e73ea6
to
01583a9
Compare
Yes, we already have it in negative scenarios. |
closes #758 Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321
force-pushed
the
ezayats/ranges
branch
2 times, most recently
from
f32138d
to
11563ab
Compare
carpawell
approved these changes
Jun 5, 2024
roman-khimov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.