Accounts in eacl #976
Merged
Accounts in eacl #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgenii Baidakov <[email protected]>
api/handler/acl.go
Outdated
| @@ -493,14 +493,18 @@ func (h *handler) PutBucketPolicyHandler(w http.ResponseWriter, r *http.Request) | |||
| } | |||
|
|
|||
| func parseACLHeaders(header http.Header, key *keys.PublicKey) (*AccessControlPolicy, error) { | |||
There was a problem hiding this comment.
Why not? We don't have a goal of completely removing pub keys support
There was a problem hiding this comment.
But I think the only thing you do now with this key is getting an account. In which case the key is irrelevant and as S3 never sets any keys into ACLs, why should it care about them during parsing? I do want to make this easier to use in the end, we only have keys in NeoFS itself for compatibility and that can be reconsidered after some transition period.
There was a problem hiding this comment.
I agree with this point of view. Replaced with user.ID
smallhive
force-pushed
the
accounts-in-eacl
branch
from
33a4c84
to
cb9212d
Compare
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
accounts-in-eacl
branch
from
cb9212d
to
970829d
Compare
roman-khimov
approved these changes
Aug 14, 2024
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs nspcc-dev/neofs-api#278
The changes require test changes as well.
ACL owner will be changed from
{ "Owner": { "DisplayName": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM", "ID": "033845e8ebc78251029261cbc0e9bae104d2b7cc9fee5c79720a30332d5b3d1aa0" }, "Grants": [ { "Grantee": { "DisplayName": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM", "ID": "033845e8ebc78251029261cbc0e9bae104d2b7cc9fee5c79720a30332d5b3d1aa0", "Type": "CanonicalUser" }, "Permission": "FULL_CONTROL" } ] }to
{ "Owner": { "DisplayName": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM", "ID": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM" }, "Grants": [ { "Grantee": { "DisplayName": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM", "ID": "Nj9FF9jYTsyX2XniTw5Kqy3Zf91nbhdYiM", "Type": "CanonicalUser" }, "Permission": "FULL_CONTROL" } ] }