Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chunked reader if content market with STREAMING-AWS4-HMAC-SHA256-PAYLOAD header #1011

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Use chunked reader if content market with STREAMING-AWS4-HMAC-SHA256-PAYLOAD header #1011

merged 1 commit into from
Sep 30, 2024

Conversation

smallhive
Copy link
Contributor

Closes #1009.

roman-khimov
roman-khimov reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an appropriate commit message (short header, some description in the message).

api/auth/center.go Outdated Show resolved Hide resolved
@roman-khimov
Copy link
Member

Please provide an appropriate commit message (short header, some description in the message).

And two commits are not really needed here.

@smallhive
*: Use chunked according to headers
c6d7474 
Closes #1009.

The amazon docs https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html chunked payload maybe sent without `content-encoding:aws-chunked` header. Meanwhile the header `x-amz-content-sha256:STREAMING-AWS4-HMAC-SHA256-PAYLOAD` still should exists.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the 1009-putobject-chunk-signature-in-saved-object branch from 1d079eb to c6d7474 Compare September 30, 2024 15:05
@smallhive
Copy link
Contributor Author

Updated

@roman-khimov roman-khimov merged commit eecea8f into master Sep 30, 2024
16 checks passed
@roman-khimov roman-khimov deleted the 1009-putobject-chunk-signature-in-saved-object branch September 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EESergey EESergey EESergey approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PutObject: chunk-signature in saved object
3 participants
@smallhive @roman-khimov @EESergey