-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache network settings #251
Cache network settings #251
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
+ Coverage 22.79% 23.61% +0.81%
==========================================
Files 18 19 +1
Lines 3672 4731 +1059
==========================================
+ Hits 837 1117 +280
- Misses 2677 3455 +778
- Partials 158 159 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any other places where network info is used? Can they reuse this cache?
d29fdfe
to
6a0bccb
Compare
6a0bccb
to
e1cf560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update getEpochDurations
and getCurrentEpoch
.
Closes #247. Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
e1cf560
to
2b5cecd
Compare
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
In general it's OK, but now some tests fail here: https://rest.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/141-1729604693/index.html#suites/21ade783424f8b7f50534d1bb781c71b/2824020f8d392ae/ @evgeniiz321, is there any forced epoch tick there? Can they be fixed to handle cached epochs? |
Signed-off-by: Evgenii Baidakov <[email protected]>
Closes #247.