Add wallet connect for the new object requests #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana-nspcc
force-pushed
the
234-fix-wallet-connect
branch
from
8834b3e
to
00469c6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 22.08% 21.88% -0.21%
==========================================
Files 17 17
Lines 3319 3583 +264
==========================================
+ Hits 733 784 +51
- Misses 2450 2639 +189
- Partials 136 160 +24 ☔ View full report in Codecov by Sentry. |
Header parameters `X-Bearer-Signature`, `X-Bearer-Signature-Key`, and query
parameters `walletConnect`, `fullBearer` were added to the new GET and HEAD
object requests `/objects/{cid}/by_id/{oid}` and `/objects/{cid}/by_attribute/{oid}`.
This ensures consistency of the requests using the new API, as the deprecated
requests use an authorization scheme with wallet connect.
Signed-off-by: Tatiana Nesterenko <[email protected]>
Signed-off-by: Tatiana Nesterenko <[email protected]>
…d `by_attribute` Signed-off-by: Tatiana Nesterenko <[email protected]>
Header parameters `X-Bearer-Signature`, `X-Bearer-Signature-Key`, and query
parameters `walletConnect`, `fullBearer` were added to the new POST object
requests `/objects/{cid}`.
This ensures consistency of the requests using the new API, as the deprecated
requests use an authorization scheme with wallet connect.
Signed-off-by: Tatiana Nesterenko <[email protected]>
Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
force-pushed
the
234-fix-wallet-connect
branch
from
00469c6
to
9de9307
Compare
Signed-off-by: Tatiana Nesterenko <[email protected]>
Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
force-pushed
the
234-fix-wallet-connect
branch
from
9de9307
to
a4827bb
Compare
smallhive
approved these changes
Aug 16, 2024
Yes, I've prepared a separate branch for it, but since it's not related to this issue, I was going to push it after this branch is merged into master. |
roman-khimov
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #234.