Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Drop version field from ContainerInfo scheme #186

Closed
wants to merge 1 commit into from

Conversation

cthulhu-rider
Copy link
Contributor

The field is unused, cannot be set on creation and can be misleading about container versioning.

From now getting and listing ops respond w/o this field.

The field is unused, cannot be set on creation and can be misleading
about container versioning.

From now getting and listing ops respond w/o this field.

Signed-off-by: Leonard Lyubich <[email protected]>
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.02%. Comparing base (067e507) to head (5840009).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   22.95%   23.02%   +0.07%     
==========================================
  Files          14       14              
  Lines        3572     3561      -11     
==========================================
  Hits          820      820              
+ Misses       2631     2620      -11     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review March 22, 2024 14:47
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's displayed in Panel along with other metadata and I don't consider it harmful. It is a part of the container structure.

@cthulhu-rider
Copy link
Contributor Author

It's displayed in Panel

UI will show everything regardless of whether it is needed or not. At the moment there are no use cases, so I would remove the unnecessary

@roman-khimov
Copy link
Member

It's somewhat ironic that the field was added in #27 to solve #25.

@roman-khimov
Copy link
Member

I don't know how it can be used by the client, but it exists in the structure and can be useful in future if this structure changes in any way. Therefore, nspcc-dev/neofs-sdk-go#581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants