-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add HTTP-like object getter #114
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 15.50% 13.70% -1.81%
==========================================
Files 10 10
Lines 1838 2080 +242
==========================================
Hits 285 285
- Misses 1523 1765 +242
Partials 30 30 ☔ View full report in Codecov by Sentry. |
22efb6e
to
8e2b1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the problems we currently have? Bearer token?
Have you tried neofs-testcases with it?
Looks rather legit otherwise.
gen/restapi/operations/get_container_object_responces_enhanced.go
Outdated
Show resolved
Hide resolved
gen/restapi/operations/get_container_object_responces_enhanced.go
Outdated
Show resolved
Hide resolved
gen/restapi/operations/get_container_object_responces_enhanced.go
Outdated
Show resolved
Hide resolved
gen/restapi/operations/get_container_object_responces_enhanced.go
Outdated
Show resolved
Hide resolved
8e2b1b1
to
4a394ec
Compare
gen/restapi/operations/get_container_object_responses_enhanced.go
Outdated
Show resolved
Hide resolved
gen/restapi/operations/get_container_object_responses_enhanced.go
Outdated
Show resolved
Hide resolved
758b093
to
9cfbf88
Compare
7e11f03
to
482437f
Compare
482437f
to
c7e7b12
Compare
@cthulhu-rider, I cannot comment directly here: #114 (comment). But |
but why? try again to follow ur #114 (comment), it must lead to the active thread where u should be able to comment. Afaik GH duplicates review comments left in threads in form of inline uncommentable blocks, im tryin to avoid them but sometimes they intrude ;( think u meant them
yeah that's for sure, but regardless of this we need to check |
Add `GET /get/{cid}/{oid}` and `HEAD /get/{cid}/{oid}` APIs. Signed-off-by: Tatiana Nesterenko <[email protected]>
c7e7b12
to
14b20e6
Compare
Add
GET /get/{cid}/{oid}
andHEAD /get/{cid}/{oid}
APIs.Close #109.