node: fix panic in error cases, fix #2970 #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internalErr has some buffer to accept multiple errors, but it only processes one of them, so if we have some cascading failures with multiple components reporting an error some of them will end up panicking because of closed channed. It's not very critical since the node is to die anyway, but it's nothing good either. This particular case shouldn't really happen after #2996, but leaving this channel open is better than panic in case some other events lead to multiple sends to it. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3003 +/- ##
=======================================
Coverage 23.07% 23.07%
=======================================
Files 789 789
Lines 58687 58686 -1
=======================================
Hits 13542 13542
+ Misses 44263 44262 -1
Partials 882 882 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Nov 7, 2024
| @@ -36,7 +36,7 @@ attribute, which is used for container domain name in NNS contracts (#2954) | |||
| - Use org-wide linter (#2943) | |||
| - Timestamps are no longer produced in logs if not running with TTY (#2964) | |||
| - In inner ring config, default ports for TCP addresses are used if they are missing (#2969) | |||
| - Metabase is refilled if an object exists in write-cache but is missing in metabase (#2977) | |||
| - Metabase is refilled if an object exists in write-cache but is missing in metabase (#2977) | |||
There was a problem hiding this comment.
hm, this is already like an additional CI check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internalErr has some buffer to accept multiple errors, but it only processes one of them, so if we have some cascading failures with multiple components reporting an error some of them will end up panicking because of closed channed. It's not very critical since the node is to die anyway, but it's nothing good either.
This particular case shouldn't really happen after #2996, but leaving this channel open is better than panic in case some other events lead to multiple sends to it.