metabase: Open(readOnly) moves metabase in RO mode
#3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when the metabase is opened with the readOnly flag, it sets the mode to ReadOnly. Add test. Closes #2889. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3000 +/- ##
==========================================
+ Coverage 23.15% 23.16% +0.01%
==========================================
Files 789 789
Lines 58815 58818 +3
==========================================
+ Hits 13619 13627 +8
+ Misses 44312 44308 -4
+ Partials 884 883 -1 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Nov 6, 2024
roman-khimov
approved these changes
Nov 7, 2024
roman-khimov
deleted the
2889-metadbopenreadonly-does-not-move-metabase-in-ro-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2889.